[css-view-transitions-2] Allow auto as a keyword
#10922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`auto` resolves to either the element's ID, or to a unique identifier that is stable for the duration of the transition and is not web-observable. Resolution: w3c#8320 (comment) Closes w3c#8320
khushalsagar
approved these changes
Sep 23, 2024
Co-authored-by: Khushal Sagar <[email protected]>
khushalsagar
approved these changes
Oct 1, 2024
Co-authored-by: Khushal Sagar <[email protected]>
noamr
added a commit
to noamr/csswg-drafts
that referenced
this pull request
Oct 2, 2024
* [css-view-transitions-2] Allow `auto` as a keyword `auto` resolves to either the element's ID, or to a unique identifier that is stable for the duration of the transition and is not web-observable. Resolution: w3c#8320 (comment) Closes w3c#8320 * Fix refs * Tighten definition of unique string * Update css-view-transitions-2/Overview.bs Co-authored-by: Khushal Sagar <[email protected]> * Handle scoping * Change scoping text * Change scoping text * Update Overview.bs Co-authored-by: Khushal Sagar <[email protected]> --------- Co-authored-by: Khushal Sagar <[email protected]>
cdoublev
reviewed
Oct 2, 2024
|
|
||
| ## Additions to 'view-transition-name' ## {#additions-to-vt-name} | ||
|
|
||
| In addition to the existing values, the 'view-transition-name' also accepts an <dfn for=view-transition-name type=value export>auto</dfn> keyword. |
There was a problem hiding this comment.
It would have been useful for w3c tools, to define it with New values in a (partial) property definition table (exemple).
There was a problem hiding this comment.
Oh I was not aware of this, thanks. I'll upload a revision.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 4, 2024
This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364180}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 4, 2024
This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364180}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 4, 2024
This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364180}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 10, 2024
…testonly Automatic update from web-platform-tests Implement view-transition-name: auto This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364180} -- wpt-commits: 1a1d4ed2385977cf33fe1f5da2023c287a2f7288 wpt-pr: 48469
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 15, 2024
…testonly Automatic update from web-platform-tests Implement view-transition-name: auto This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Reviewed-by: Khushal Sagar <khushalsagarchromium.org> Cr-Commit-Position: refs/heads/main{#1364180} -- wpt-commits: 1a1d4ed2385977cf33fe1f5da2023c287a2f7288 wpt-pr: 48469 UltraBlame original commit: 295ba3c31624ede939a6fd56f7279d8e3f2b2120
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 15, 2024
…testonly Automatic update from web-platform-tests Implement view-transition-name: auto This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Reviewed-by: Khushal Sagar <khushalsagarchromium.org> Cr-Commit-Position: refs/heads/main{#1364180} -- wpt-commits: 1a1d4ed2385977cf33fe1f5da2023c287a2f7288 wpt-pr: 48469 UltraBlame original commit: 295ba3c31624ede939a6fd56f7279d8e3f2b2120
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 15, 2024
…testonly Automatic update from web-platform-tests Implement view-transition-name: auto This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <nrosenthalchromium.org> Reviewed-by: Khushal Sagar <khushalsagarchromium.org> Cr-Commit-Position: refs/heads/main{#1364180} -- wpt-commits: 1a1d4ed2385977cf33fe1f5da2023c287a2f7288 wpt-pr: 48469 UltraBlame original commit: 295ba3c31624ede939a6fd56f7279d8e3f2b2120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoresolves to either the element's ID, or to a unique identifier that is stable for the duration of the transition and is not web-observable.Resolution: #8320 (comment)
Closes #8320