[css-borders-4] Specify corner-shape based on superellipse
#11606
+155
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specifies the `corner-shape` group, including: - general description and interaction with border-radius - all the individual corners, side shorthands, and overall shorthand - multiple keywords, and how they translate to a `superellipse()` - The superellipse formula, and how it is rendered - How the exponent of the superellipse interpolates Open issues (will open separately): - Add a few examples - Resolve on "straight" vs "none" for the convex angle. - Resolve on the exact interpolation formula - Define restrictions for border rendering Closes w3c#10993 Based on resolution w3c#10993 (comment)
|
(Sorry for the multiple reviewers, but it's probably a good idea to have a few eyes on this) |
fserb
reviewed
Jan 30, 2025
tabatkins
requested changes
Jan 30, 2025
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
tabatkins
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifies the
corner-shapegroup, including:superellipse()Open issues (will open separately):
This overwrites the existing
corner-shapedefinition.Closes #10993
Based on resolution #10993 (comment)