Used advisory terminology in guideline document #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document is a guideline. No matter how good its advice is, it is only advice. Except when conveying requirements established elsewhere authoritatively, guidelines should refrain from using phrasing like "is required", because guidelines cannot actually require anything.
plehegar
approved these changes
Sep 16, 2025
|
adding @koalie in this loop since that page is maintained by comm |
koalie
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document is a guideline. No matter how good its advice is, it is only advice. Except when conveying requirements established elsewhere authoritatively, guidelines should refrain from using phrasing like "is required", because guidelines cannot actually require anything.
In this PR, I suggest changing one such instance from "is required" to "is advised". No disagreement about the advice given, but as it isn't an actual formal requirement, it should not be presented as such.