Split profiles into track folders (#1452)

* remove pp2002, closes #1431

* remove profile-amended

* fix test

* remove unused test file

* split profiles into track folders

* make track/profiles work

* Revert "make track/profiles work"

This reverts commit f52af89.

* Revert "Revert "make track/profiles work""

This reverts commit 14e624b.

* add all profiles under track

* align profiles

* give error message when doing unecessary rule remove

* Update lib/profiles/profileUtil.js

Co-authored-by: Denis Ah-Kang <[email protected]>

* Update lib/rules/metadata/profile.js

Co-authored-by: Denis Ah-Kang <[email protected]>

* Update lib/rules/metadata/profile.js

Co-authored-by: Denis Ah-Kang <[email protected]>

* Update lib/profiles/TR/Recommendation/FPWD.js

Co-authored-by: Denis Ah-Kang <[email protected]>

* remove usage rule from DRY, CRY, CRYD, fix lint

* fix test

Co-authored-by: Denis Ah-Kang <[email protected]>

lib/profiles/SUBM.js

@@ -2,8 +2,10 @@
 
 exports.name = 'Submission';
 
-const base = require('./base');
+const profileUtil = require('./profileUtil');
 
-exports.rules = base.extendWithInserts({
-    'headers.logo': require('../rules/headers/subm-logo'),
-});
+exports.rules = profileUtil.insertAfter(
+    require('./base').rules,
+    'headers.logo',
+    require('../rules/headers/subm-logo')
+);

lib/profiles/SUBM/MEM-SUBM.js

@@ -6,11 +6,13 @@ exports.config = {
     submissionType: 'member',
 };
 
-const base = require('../base');
-let rules = base.insertAfter(require('../SUBM').rules, 'headers.w3c-state', [
-    require('../../rules/headers/memsub-copyright'),
-]);
-rules = base.insertAfter(
+const profileUtil = require('../profileUtil');
+let rules = profileUtil.insertAfter(
+    require('../SUBM').rules,
+    'headers.w3c-state',
+    [require('../../rules/headers/memsub-copyright')]
+);
+rules = profileUtil.insertAfter(
     rules,
     'sotd.supersedable',
     require('../../rules/sotd/submission')

lib/profiles/TR.js

@@ -1,19 +1,20 @@
 // base profile for all things TR
 exports.name = 'TR';
 
-const base = require('./base');
+const profileUtil = require('./profileUtil');
+const base = require('./base').rules;
 
-exports.rules = base.extendWithInserts({
-    'headers.w3c-state': [
-        require('../rules/headers/github-repo'),
-        require('../rules/headers/copyright'),
-    ],
-    'sotd.supersedable': [
-        require('../rules/sotd/stability'),
-        require('../rules/sotd/publish'),
-        require('../rules/sotd/draft-stability'),
-        require('../rules/sotd/pp'),
-        require('../rules/sotd/charter'),
-        require('../rules/sotd/process-document'),
-    ],
-});
+let rules = profileUtil.insertAfter(base, 'headers.w3c-state', [
+    require('../rules/headers/github-repo'),
+    require('../rules/headers/copyright'),
+]);
+
+rules = profileUtil.insertAfter(rules, 'sotd.supersedable', [
+    require('../rules/sotd/stability'),
+    require('../rules/sotd/publish'),
+    require('../rules/sotd/pp'),
+    require('../rules/sotd/charter'),
+    require('../rules/sotd/process-document'),
+]);
+
+exports.rules = rules;

lib/profiles/TR/Note/DNOTE-Echidna.js

@@ -0,0 +1,13 @@
+// TODO: merge all Echidna files.
+exports.name = 'DNOTE-Echidna';
+const base = require('./DNOTE');
+
+exports.config = base.config;
+
+// customize rules
+const profileUtil = require('../../profileUtil');
+const rules = profileUtil.insertAfter(base.rules, 'sotd.process-document', [
+    require('../../../rules/echidna/todays-date'),
+]);
+
+exports.rules = rules;

lib/profiles/TR/Note/DNOTE.js

@@ -0,0 +1,18 @@
+exports.name = 'DNOTE';
+const base = require('./note-base');
+
+// customize config
+const config = {
+    status: 'DNOTE',
+    longStatus: 'Group Draft Note',
+    styleSheet: 'W3C-DNOTE',
+};
+exports.config = { ...base.config, ...config };
+
+// customize rules
+const profileUtil = require('../../profileUtil');
+const rules = profileUtil.insertAfter(base.rules, 'sotd.pp', [
+    require('../../../rules/sotd/draft-stability'),
+]);
+
+exports.rules = rules;

lib/profiles/TR/Note/NOTE-Echidna.js

@@ -0,0 +1,9 @@
+exports.name = 'NOTE-Echidna';
+const base = require('./NOTE');
+
+exports.config = base.config;
+
+const profileUtil = require('../../profileUtil');
+exports.rules = profileUtil.insertAfter(base.rules, 'sotd.process-document', [
+    require('../../../rules/echidna/todays-date'),
+]);

lib/profiles/TR/Note/NOTE.js

@@ -0,0 +1,12 @@
+exports.name = 'NOTE';
+const base = require('./note-base');
+
+// customize config
+const config = {
+    status: 'NOTE',
+    longStatus: 'Group Note',
+    styleSheet: 'W3C-NOTE',
+};
+exports.config = { ...base.config, ...config };
+
+exports.rules = base.rules;

lib/profiles/TR/Note/STMT.js

@@ -0,0 +1,12 @@
+exports.name = 'STMT';
+const base = require('./note-base');
+
+// customize config
+const config = {
+    status: 'STMT',
+    longStatus: 'Statement',
+    styleSheet: 'W3C-STMT',
+};
+exports.config = { ...base.config, ...config };
+
+exports.rules = base.rules;

lib/profiles/TR/Note/note-base.js

@@ -0,0 +1,13 @@
+exports.config = {
+    track: 'Note',
+};
+
+// customize rules
+const base = require('../../TR');
+const profileUtil = require('../../profileUtil');
+
+const rules = profileUtil.insertAfter(base.rules, 'sotd.pp', [
+    require('../../../rules/sotd/deliverer-note'),
+]);
+
+exports.rules = rules;