Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Enforcement in timer functions from spec #114

Closed
wants to merge 1 commit into from

Conversation

vrana
Copy link
Collaborator

@vrana vrana commented Jan 17, 2019

It calls HostEnsureCanCompileStrings which is covered below.

It calls HostEnsureCanCompileStrings which is covered below.
@koto
Copy link
Member

koto commented Jan 17, 2019

That one is interesting. We cannot for now base the spec on HostEnsureCanCompileStrings, as that algorithm doesn't accept the object (usually; a string with the code) to be compiled - TC39#938, so we can't at that point make any decision whether to reject or accept.

We did solve it in setTimeout / setInterval spec-wise, as those are web platform features. Reusing HostEnsureCanCompileStrings does sound like a better place to hook the spec on, but it requires changes to EcmaScript. For now I decided to leave it as-is, given that the implementation matches (set(Timeout|Interval) are covered; eval is ignored).

@vrana
Copy link
Collaborator Author

vrana commented Jan 18, 2019

I see. TT spec in String compilation writes HostEnsureCanCompileStrings but links EnsureCSPDoesNotBlockStringCompilation which confused me. I'll send another pull-request to fix it.

@vrana vrana closed this Jan 18, 2019
@vrana vrana deleted the timer branch January 18, 2019 09:52
@vrana
Copy link
Collaborator Author

vrana commented Jan 18, 2019

#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants