Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword self-asserted VC in VP text to remove MUST. #1580

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

BigBlueHat
Copy link
Member

@BigBlueHat BigBlueHat commented Jan 13, 2025

The original statement was found to be untestable. This new text provides explanatory text instead.

NOTE: the goal of this change is to avoid this text being "at risk" while keeping the intention of the text.

@jandrieu I believe this was originally your text, so please let us know if you're OK with this change.

Thanks!
🎩


Preview | Diff

The original statement was found to be untestable. This new text
provides explanatory text instead.
@BigBlueHat BigBlueHat force-pushed the fix-self-asserted-text branch from f3694a9 to ae6c07b Compare January 13, 2025 17:10
Copy link
Contributor

@jandrieu jandrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@msporny msporny added CR2 normative The PR is a normative change to the CR specification labels Jan 13, 2025
index.html Outdated Show resolved Hide resolved
@msporny msporny added editorial Purely editorial changes to the specification. and removed normative The PR is a normative change to the CR specification labels Jan 15, 2025
@iherman
Copy link
Member

iherman commented Jan 15, 2025

The issue was discussed in a meeting on 2025-01-15

  • no resolutions were taken
View the transcript

1.2. Reword self-asserted VC in VP text to remove MUST. (pr vc-data-model#1580)

See github pull request vc-data-model#1580.

Brent Zundel: This rewords the self asserted VP test to remove the MUST. The test suite determined that this statement was untestable.
… This is a normative change that fixes a bug. Has lots of approval, expect it to be merged after review time passed.

Manu Sporny: process question for ivan, this has been determined unimplementable even though it is normative. Is this change going to be okay.

Ivan Herman: yep should be fine.
… I don't think the normative label on the PR is justified. It isnt changing a feature it makes things more precicse.

Manu Sporny: I can change to editorial.

@msporny
Copy link
Member

msporny commented Jan 19, 2025

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit ef78b1e into main Jan 19, 2025
1 check passed
@msporny msporny deleted the fix-self-asserted-text branch January 19, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 editorial Purely editorial changes to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants