Skip to content

3984 labels descriptions #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 22, 2025
Merged

3984 labels descriptions #4212

merged 29 commits into from
Apr 22, 2025

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Jan 29, 2025

Closes #3984 by incorporating the idea of accuracy into 2.4.6 Headings and Labels, and reinforcing the relationship between 2.4.6 and 3.3.2 Labels or Instructions.

Also took the opportunity to use em dashes instead of dashes, where appropriate.

put Success Criterion lower case except where it specifies a number, as per https://github.com/w3c/wcag/wiki/WCAG-2-style-guide
This reverts commit 7bdeee0.
change "this" to "that"; made dashes be em dashes (without spaces)
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 46c1dd2
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6807af8a4dd88100084610d5
😎 Deploy Preview https://deploy-preview-4212--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

added "accuracy" to several examples and passages
@mbgower mbgower marked this pull request as ready for review January 29, 2025 22:32
@w3c w3c deleted a comment from ashstone1 Feb 23, 2025
@TestPartners
Copy link

A semi-colon would be a more appropriate separator than a dash or hyphen.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no improvement changing xxx - xxx to xxx-xxx.

@patrickhlauke
Copy link
Member

I see no improvement changing xxx - xxx to xxx-xxx.

for context, the change here uses an actual dash character rather than a - minus sign. and in traditional typography, there's no spaces around dashes (or rather, generally you'd want a hairline space)

@patrickhlauke
Copy link
Member

x-ref #4096

@patrickhlauke patrickhlauke self-assigned this Feb 28, 2025
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest more gracefully embedding the cross-reference to 3.3.2, rather than in an parenthetical

Update to swap out sentences in second paragraph, as discussed on TF call
@bruce-usab
Copy link
Contributor

Discussed on backlog call 3/7. Kept in Drafted.

@mbgower
Copy link
Contributor Author

mbgower commented Apr 4, 2025

A semi-colon would be a more appropriate separator than a dash or hyphen.

I don't find that a semi-colon would be an improvement in most cases, and in at least one case it would not make sense because the dash is not separating two independent clauses. Note that all this PR does in this context is to update the character to proper usage (from a dash to an em dash). That change is not the focus of the PR.

@mraccess77
Copy link

I'm still unclear from the wording updates if a visual label was descriptive but the accessible name was not descriptive then would SC 4.1.2, 1.3.3, 2.5.3 fail and not 2.4.6? Is 2.4.6 just about visible labels?

@mbgower
Copy link
Contributor Author

mbgower commented Apr 11, 2025

I'm still unclear from the wording updates if a visual label was descriptive but the accessible name was not descriptive then would SC 4.1.2, 1.3.3, 2.5.3 fail and not 2.4.6? Is 2.4.6 just about visible labels?

An interesting question, but it seems somewhat orthogonal to the original issue and this PR?
I believe it might make sense to peel this off as a new issue and address it there (and make a PR to address, if necessary). Would that be acceptable to you @mraccess77 ?

@mraccess77
Copy link

An interesting question, but it seems somewhat orthogonal to the original issue and this PR? I believe it might make sense to peel this off as a new issue and address it there (and make a PR to address, if necessary). Would that be acceptable to you @mraccess77 ?

Yes, I am fine with that.

mbgower added 2 commits April 21, 2025 09:39
putting "success criterion" lower case where it does not directly precede a number
@mbgower
Copy link
Contributor Author

mbgower commented Apr 21, 2025

Would suggest more gracefully embedding the cross-reference to 3.3.2, rather than in an parenthetical

@patrickhlauke this was accomplished in 2f6acb6

Merge is blocked by your request. Could you please review and indicate your request resolved, or offer updated feedback?

@mbgower mbgower requested a review from patrickhlauke April 22, 2025 13:14
@mbgower mbgower dismissed patrickhlauke’s stale review April 22, 2025 15:04

A change was made in response to Patrick's request for a change, and the updated language was part of the WG response period, and received good support.

@mbgower mbgower merged commit dbb3207 into main Apr 22, 2025
5 checks passed
@mbgower mbgower deleted the 3984-labels-descriptions branch April 22, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore the need for accuracy/correctness to 3.3.2 Labels or Instructions
7 participants