-
Notifications
You must be signed in to change notification settings - Fork 285
3984 labels descriptions #4212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3984 labels descriptions #4212
Conversation
put Success Criterion lower case except where it specifies a number, as per https://github.com/w3c/wcag/wiki/WCAG-2-style-guide
This reverts commit 7bdeee0.
change "this" to "that"; made dashes be em dashes (without spaces)
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added "accuracy" to several examples and passages
A semi-colon would be a more appropriate separator than a dash or hyphen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no improvement changing xxx - xxx
to xxx-xxx
.
for context, the change here uses an actual |
x-ref #4096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest more gracefully embedding the cross-reference to 3.3.2, rather than in an parenthetical
Update to swap out sentences in second paragraph, as discussed on TF call
Discussed on backlog call 3/7. Kept in Drafted. |
I don't find that a semi-colon would be an improvement in most cases, and in at least one case it would not make sense because the dash is not separating two independent clauses. Note that all this PR does in this context is to update the character to proper usage (from a dash to an em dash). That change is not the focus of the PR. |
I'm still unclear from the wording updates if a visual label was descriptive but the accessible name was not descriptive then would SC 4.1.2, 1.3.3, 2.5.3 fail and not 2.4.6? Is 2.4.6 just about visible labels? |
An interesting question, but it seems somewhat orthogonal to the original issue and this PR? |
Yes, I am fine with that. |
putting "success criterion" lower case where it does not directly precede a number
@patrickhlauke this was accomplished in 2f6acb6 Merge is blocked by your request. Could you please review and indicate your request resolved, or offer updated feedback? |
A change was made in response to Patrick's request for a change, and the updated language was part of the WG response period, and received good support.
Closes #3984 by incorporating the idea of accuracy into 2.4.6 Headings and Labels, and reinforcing the relationship between 2.4.6 and 3.3.2 Labels or Instructions.
Also took the opportunity to use em dashes instead of dashes, where appropriate.