-
Notifications
You must be signed in to change notification settings - Fork 309
Replace straggler WAI/WCAG21 links to WAI/WCAG22 #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ah, this PR currently fails the "Reflect status" check, but no idea what that is (and the error it shows in the log is not very helpful in that regard). is this the check that wants to avoid a mix of normative and non-normative files being changed in the same PR? and if so, should i bifurcate this PR into two separate ones? (and also, can the error messaging in the check https://github.com/w3c/wcag/actions/runs/17083042062/job/48441437816?pr=4564#step:9:7 be made a bit more human-understandable?) |
5d4244f
to
47e948f
Compare
@kfranqueiro is Patrick's analysis correct? Is this just flagging him on a mixed normative/non-normative PR? |
If you scroll to the top of the check and expand the Annotations section (or click Summary and scroll down which shows the same annotations), you will see the human-readable version:
This isn't reflected as clearly within the log in order to allow running all of the checks at once rather than short-circuiting as soon as one fails. IIRC I also tried separating each to its own job but that proved less readable for other reasons. |
do we want/need to separate this PR into two then? |
Assuming so, done #4586 |
Closes #3635