Repository navigation
Check VideoFrame buffer size against coded size - #990
Merged
Merged
Conversation
The VideoFrame(data, init) constructor computed its required allocation size from the visible rect, so a buffer too small for the coded frame was accepted. Compute the layout over the coded rect instead, matching Chromium. Fixes #516
Djuffin
self-requested a review
November 8, 2026 00:45
Djuffin
approved these changes
Nov 8, 2026
github-actions Bot
added a commit
that referenced
this pull request
Nov 8, 2026
SHA: 0755634 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VideoFrame(data, init)constructor computed its required allocation size from the visible rect, so a buffer too small for the coded frame was accepted. The size check now uses the layout computed over the coded rect, matching Chromium, which throwsdata is not large enough.for the same input.Fixes #516
Preview | Diff