Skip to content

Update "emulation.setLocaleOverride" to also override "Accept-Language" header. #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update "emulation.setLocaleOverride" to also override "Accept-Language" header. #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9635,18 +9635,23 @@ navigables|:
navigables. In that case it's unclear in which order to override the headers.

1. [=Update headers=] with |request| and |session|'s
[=session/extra headers=]' [=extra headers/default headers=]
[=session/extra headers=]' [=extra headers/default headers=].

1. Let |user context headers| be |session|'s [=session/extra headers=]'
[=extra headers/user context headers=].

1. Let |accept language override| be a null.

1. For |navigable| in |related navigables|:

1. Let |user context| be |navigable|'s [=associated user context=].

1. If |user context headers| [=map/contains=] |user context|
then [=update headers=] with |request| and
|user context headers|[|user context|]
|user context headers|[|user context|].

1. If [=locale overrides map=] [=map/contains=] |user context|,
set |accept language override| to [=locale overrides map=][|user context|].

1. Let |navigable headers| be |session|'s [=session/extra headers=]'
[=extra headers/navigable headers=].
Expand All @@ -9659,6 +9664,17 @@ navigables|:
1. If |navigable headers| contains |top-level traversable|
[=update headers=] with |request| and |navigable headers|[|top-level traversable|].

1. If [=locale overrides map=] [=map/contains=] |top-level traversable|,
set |accept language override| to [=locale overrides map=][|top-level traversable|].

1. If |accept language override| is not null:

1. Let |accept language headers| be an empty [=/header list=].

1. Append [=/header=] ("Accept-Language", |accept language override|) to |accept language headers|.

1. [=Update headers=] with |request| and |accept language headers|.

</div>

<div algorithm="remote end steps for network.setExtraHeaders">
Expand Down