Add browsingContext.navigationCommitted event and wait for it when no wait condition is provided #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/navigation-committed
branch
from
1573c2f to
31fd732
Compare
6 tasks
OrKoN
changed the title
sadym-chromium
approved these changes
Jan 14, 2025
OrKoN
commented
Jan 14, 2025
sadym-chromium
approved these changes
Jan 14, 2025
whimboo
reviewed
Jan 14, 2025
whimboo
reviewed
Jan 15, 2025
There was a problem hiding this comment.
What should we do with the browsingContext.navigationAborted event? Should we deprecate it? See #788 (comment)
what is the specific reason for deprecating navigationAborted? I think we can discuss it separately. |
3 tasks
Co-authored-by: Henrik Skupin <[email protected]>
See the details in the referenced comment. That's all what I got. Happy to move it to a follow-up. |
OrKoN
changed the title
jgraham
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #788
HTML spec: whatwg/html#10910
Preview | Diff