Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in browser.SetClientWindowStateParameters #857

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

tabatkins
Copy link
Member

@tabatkins tabatkins commented Jan 14, 2025

Fixes #853.


Preview | Diff

Co-authored-by: Alex Rudenko <[email protected]>
@tabatkins
Copy link
Member Author

Ok, I went ahead and just accepted the suggestion to use parens instead, which is equally valid and has the benefit of not having its correctness in question. However, looks like GitHub is fighting against itself, since accepting a suggestion counts as a merge commit to the branch, which violates the rebase-only strategy. Sigh, GitHub, this is your own fault!

Anyway, if an editor wants to just make the change themselves and close this, that's fine. ^_^

@whimboo
Copy link
Contributor

whimboo commented Feb 27, 2025

Ok, I went ahead and just accepted the suggestion to use parens instead, which is equally valid and has the benefit of not having its correctness in question. However, looks like GitHub is fighting against itself, since accepting a suggestion counts as a merge commit to the branch, which violates the rebase-only strategy. Sigh, GitHub, this is your own fault!

That's actually not the problem. If you read the 2nd line in that box you will see that a review is required. Once we did the merge will be fine.

@whimboo whimboo changed the title Use the right slash. Fixes #853 Fix syntax error in browser.SetClientWindowStateParameters Feb 27, 2025
@whimboo whimboo merged commit 3892dc0 into w3c:main Feb 27, 2025
5 checks passed
github-actions bot added a commit that referenced this pull request Feb 27, 2025
SHA: 3892dc0
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in browser.SetClientWindowStateParameters definition?
4 participants