Align navigate and reload with the HTML spec #861
Conversation
|
I am not sure if accessing the navigation ID in this way is correct (it looked like it might not be for reload). Any suggestions are welcome. |
|
@jgraham what do you think about using ongoing navigation this way? PTAL |
index.bs
Outdated
|
|
||
| 1. Return the result of [=await a navigation=] with |navigable|, |request| and | ||
| |wait condition|. | ||
| 1. Let |navigation id| be |navigable|'s [=ongoing navigation=]. |
There was a problem hiding this comment.
This actually doesn't work, and may require changes on the HTML side. The problem is that we can return from the above algorithm without starting a new navigation, and this step will get the id of some other navigation (or maybe null). Previously that was OK because we already knew the navigation id at this point, so in the next step we'd notice that a failure event had been dispatched and return. But now we need the navigation to be initiated to find the correct id.
There was a problem hiding this comment.
I wonder if the part using await for events after the navigate is also flawed, since by the time the await is called some events might have already happened?
There was a problem hiding this comment.
Hmm, looks like it probably is because await doesn't have a way to synchronously check if the resume condition was already met.
There was a problem hiding this comment.
I am not sure I am ready to propose a change to the HTML spec right now, but perhaps we could specify here that we want to yield the navigation id back to our algorithm as soon as it is defined on the step 6 and run the rest of the navigate/reload algorithm in parallel?
OrKoN
force-pushed
the
orkon/align-navigation-with-html
branch
2 times, most recently
from
316f7d4 to
61f8f59
Compare
OrKoN
force-pushed
the
orkon/align-navigation-with-html
branch
from
61f8f59 to
c7c8f7d
Compare
Closes #858
Preview | Diff