Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file prompt type #1884

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Allow file prompt type #1884

merged 3 commits into from
Mar 6, 2025

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Feb 24, 2025

Allow for file prompt type in capabilities.

Required for w3c/webdriver-bidi#883.


Preview | Diff

Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OrKoN OrKoN changed the title [WIP] Allow fileUpload prompt type [WIP] Allow file prompt type Feb 25, 2025
@sadym-chromium sadym-chromium marked this pull request as ready for review February 25, 2025 12:10
@sadym-chromium sadym-chromium changed the title [WIP] Allow file prompt type Allow file prompt type Feb 25, 2025
@sadym-chromium sadym-chromium requested a review from OrKoN February 25, 2025 12:14
@OrKoN OrKoN requested review from whimboo and jgraham February 25, 2025 12:50
sadym-chromium added a commit to w3c/webdriver-bidi that referenced this pull request Mar 5, 2025
This PR implements `input.fileDialogOpened` event and defines `unhandledPromptBehavior` for `file`. It should be accompanied by the following changes:
HTML spec: whatwg/html#11030
WebDriver Classic spec: w3c/webdriver#1884
File system access: WICG/file-system-access#452
@sadym-chromium
Copy link
Contributor Author

@juliandescottes PTAL, as you already looked into w3c/webdriver-bidi#883

@sadym-chromium sadym-chromium merged commit 3055808 into master Mar 6, 2025
2 checks passed
@sadym-chromium sadym-chromium deleted the sadym/file-upload-prompt branch March 6, 2025 11:18
github-actions bot added a commit that referenced this pull request Mar 6, 2025
SHA: 3055808
Reason: push, by sadym-chromium

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to ZRDKPoWeR/webdriver that referenced this pull request Mar 6, 2025
SHA: 3055808
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to soloinovator/webdriver that referenced this pull request Mar 6, 2025
SHA: 3055808
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to xjc90s/webdriver that referenced this pull request Mar 6, 2025
SHA: 3055808
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants