-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Build Docs and Agile Coretime - Coreify The Build Section #5811
Conversation
Please note, that to ensure the PR can be properly reviewed, follow up PRs for the new section and concerning the guides will commence after this one is merged. |
Good work! Coretime has yet to be launched on Polkadot (it takes a month or two), so modifying the concrete build section on the Polkadot Wiki is not recommended. Perhaps, do a conditional render for this new content to be shown only on the Kusama guide and modify just the Kusama sidebar with the newly added pages? Right now, https://wiki.polkadot.network/docs/learn-agile-coretime-index caters to different audiences who are trying to learn about coretime through definitions and tutorials. We can keep the structure as is. Deleting pages on the Wiki is not recommended (without conditional rendering). For the coretime for parachains, we can retain the page in the learn section and have some insightful content live there. We can move the adder tutorial to the new page you have tried to create in the build section. |
@DrW3RK That is fair, I got a bit too enthusiastic it seems 😁 how about the following?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update of these build pages. Added a few suggestions.
Some comments:
- Do we want to move the dependency installation docs from substrate.io to the Wiki? Doesn't it make sense for these installation docs to live on Polkadot SDK docs?
- Make sure there are a few reviews from the devs for these changes to the Wiki docs before pushing them on to Wiki.
I can get more feedback on this, but it makes more sense in the Wiki from my POV. Those specific docs on substrate.io are good, work well, and serve as as good basis for installing dependencies in general. I would generally like to get people away from substrate.io. If we get more feedback, I would happy to move them to polkadot-sdk-docs, if we feel it makes more sense, imo it fits well within the build section of the Wiki, as its fairly general. |
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this!
This PR focuses mainly on issue #5799, but also solves at least one aspect from issue #5793.
build-guide