Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emacs lsp-jq #12

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add emacs lsp-jq #12

merged 1 commit into from
Oct 16, 2023

Conversation

wader
Copy link
Owner

@wader wader commented Aug 18, 2023

No description provided.

@wader
Copy link
Owner Author

wader commented Aug 18, 2023

@nverno ok to add? some additional instructions needed etc?

And thanks for adding emacs support!

@nverno
Copy link

nverno commented Aug 18, 2023

Hi, I was waiting on emacs-lsp/lsp-mode#4140, which would make nverno/lsp-jq unnecessary. I'll keep you posted, thankyou!

@wader
Copy link
Owner Author

wader commented Aug 18, 2023

I see, great! thanks

@wader
Copy link
Owner Author

wader commented Aug 18, 2023

and let me know if there is something to do to make jq-lsp more emacs LSP friendly

@wader
Copy link
Owner Author

wader commented Aug 18, 2023

Oh noticed it fail on windows CI :( that has not been tested at all yet. #5

@wader
Copy link
Owner Author

wader commented Oct 16, 2023

Hey, i noticed some activity on this. Let me know if this can be merge and/or if you want some changes... you can also do your own PR that replaces this one if you like.

@nverno
Copy link

nverno commented Oct 16, 2023

Hey, it looks good! Just change the link from lsp-jq to lsp-mode now its merged. Thankyou! There isn't any additional configuration to note as of yet.

@wader wader merged commit b4707e7 into master Oct 16, 2023
@wader wader deleted the add-lsp-jq branch October 16, 2023 08:09
@wader
Copy link
Owner Author

wader commented Oct 16, 2023

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants