Fixing screenreader only checkbox in Statistics Block #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
reviewed
Mar 11, 2025
Comment on lines
+2
to
+6
| {% if value.sr_only_label %} | ||
| <h2 class="sr-only">{{value.heading}}</h2> | ||
| {% else %} | ||
| {% include "components/streamfield/blocks/heading2_block.html" with large_spacing=True value=value.heading %} | ||
| {% endif %} |
There was a problem hiding this comment.
Given that we need the same in card_section_block.html for #44, would it be simpler to update heading2_block.html to add something like {% if sr_only %}sr-only{% endif %} in the <h2>'s class?
It seems to be what the code originally intended, as this template already passed sr_only=value.sr_only_label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #43.
I used the same conditional template logic as the one for #44 for updating the cards block.
If there is a cleaner or more accessible way to address this, I am definitely open to feedback.