Repository navigation
add Next.js migration examples - #6
Merged
Merged
Conversation
Four Next.js apps migrated to Waku 1.0.0-rc.2, under fs-router/: blog-starter, the Learn dashboard, Commerce and Nextgram. The first three are derived from Vercel's MIT-licensed code and keep its license; Nextgram has no license, so it is reimplemented instead. They keep the titles of the originals, so the smoke test takes a per-example title.
Commerce returns 404 for an unknown collection, as the original does. The dashboard's login redirect carries callbackUrl again, and authenticate() follows any dashboard path rather than three fixed ones. Commerce's OG images are PNGs rendered with satori and @resvg/resvg-js, since social crawlers do not render SVG, and og:image URLs are absolute and keyed by route handle.
The mobile menu closes itself in an effect keyed on the search params, so a new object on every render closed it as soon as it opened. next/navigation returns the same object until the URL changes, and the shim now does too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four Next.js apps migrated to Waku 1.0.0-rc.2, under fs-router/: blog-starter, the Learn dashboard, Commerce and Nextgram. The first three are derived from Vercel's MIT-licensed code and keep its license; Nextgram has no license, so it is reimplemented instead. They keep the titles of the originals, so the smoke test takes a per-example title.