Repository navigation
Add an e2e spec per example - #9
Merged
Merged
Conversation
The route was declared static while its page element is dynamic, so the client reused whichever slug it fetched last: going back to /dynamic/foo after /dynamic/bar showed /dynamic/bar.
waku-jotai refetches with a POST to the RSC path, and the prerendered RSC file was served for it instead of the handler. Prerender only the HTML.
The prerendered InnerApp=1..5 files held App rather than InnerApp, so the inner count never changed in production. /no-ssr was only prerendered, so it was a 404 in dev.
The page turned every - in its slug into a space, so nidoran-female and nidoran-male matched nothing and rendered empty. The home page linked to /mr. mime, but Waku serves that static path at /mr.-mime. Links, static paths and lookups now share one toPath.
Waku does not merge robots, so the layout's index, follow was served next to a hidden product's noindex, nofollow. Pages without the tag are indexed and followed anyway.
Waku logs rendering errors through sanitizeLog, which writes each newline as a literal \n, so the patterns that expected whitespace before "at" never matched.
# Conflicts: # define-router/basic/src/waku.server.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the smoke test with one spec per example (34), each run in DEV and PRD, and fixes what they caught: