test: stub gh in GitService tests so CI does not time out - #17
Merged
Conversation
status() always runs `gh pr view` with a 5s spawn timeout. On GitHub Actions the first real gh invocation can sit until that limit, racing vitest's 5s default and failing shard 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue. Fixes the
test (1)failure on the release PR: https://github.com/wangyuling93/kimi-code/actions/runs/31871049089Problem
GitService.status()always ends withgh pr view(PR_SPAWN_TIMEOUT_MS = 5000). The suite used a realHostProcessService, so on GitHub Actions (whereghis installed) the first invocation can sit until that spawn timeout and race vitest's 5s default.Failed test:
Later cases in the same file passed because subsequent
ghcalls return quickly.What changed
Stub
ghat theIHostProcessServiceboundary. Realgit/ filesystem still run against a temp repo. Also cover the pull-request fold: success parsing and same-cwd cache.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.