Add Warp Factory definition files - #501
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a linking-test Factory tree with agents, automations, scorers, shared skills, a runner, and a thread-resolution helper. The Factory schema validates, but the helper can fail to resolve valid review threads on large PRs.
Concerns
resolve-threadsonly retrieves the first 100 GitHub review threads before indexing target IDs. A PR with more than 100 threads can pass a valid--thread-idsvalue that the script reports as not found, leaving handled review threads unresolved. Page throughreviewThreadswith cursors until all requested IDs are found or the API is exhausted.
Verdict
Checks: factory validation pass, Python syntax pass, tests n/a, visual proof n/a
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| query($owner: String!, $repo: String!, $pr: Int!) { | ||
| repository(owner: $owner, name: $repo) { | ||
| pullRequest(number: $pr) { | ||
| reviewThreads(first: 100) { |
There was a problem hiding this comment.
reviewThreads(first: 100) only fetches the first page, so valid target IDs after the first 100 threads are reported as missing and the handled review thread remains unresolved. Page through reviewThreads with cursors until every requested ID is found or the API is exhausted.
eb149c3 to
fa8e03b
Compare
fa8e03b to
86389ef
Compare
This pull request was opened by Warp to add your Factory's definition files to this directory. Once it merges, finish linking the Factory to this repository from Warp Factories; the Factory then syncs from this repository automatically.