Recognize Namespace SSH commands for warpification - #16023
Draft
warp-agent-staging[bot] wants to merge 3 commits into
Draft
warp-agent-staging[bot] wants to merge 3 commits into
warp-agent-staging[bot] wants to merge 3 commits into
Conversation
Ticket-ID: cdc0fe86-82d7-4fbf-93af-5ad533f75feb Ticket-Source: adhoc
Ticket-ID: cdc0fe86-82d7-4fbf-93af-5ad533f75feb Ticket-Source: adhoc
Ticket-ID: cdc0fe86-82d7-4fbf-93af-5ad533f75feb Ticket-Source: adhoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recognize Namespace
devbox ssh <devbox-name>andnsc ssh [<instance-id>]commands as SSH-like commands so Warp routes interactive sessions through its existing SSH warpification path.nsc sshuses token-aware parsing to reject PTY-disabled sessions and trailing remote commands while accounting for its documented flag arities. Truthy--disable-pty=<bool>and-T=<bool>values disable warpification, while false values preserve interactive detection. Barensc sshremains interactive because the CLI can prompt for an instance.devbox sshremains regex-only because this change does not infer trailing-command semantics without a complete, documented flag-arity table.The narrower
nsc scratch sshform is intentionally omitted.Linked Issue
Ad hoc factory ticket
cdc0fe86-82d7-4fbf-93af-5ad533f75feb; no GitHub issue.ready-to-specorready-to-implement. Not applicable; there is no linked GitHub issue.Testing
cargo nextest run -p warp -E 'test(terminal::ssh::util::tests)'(7 passed)./script/format(passed)cargo clippy --workspace --all-targets --tests -- -D warnings(passed)cargo clippy -p warp --all-targets --tests -- -D warnings(passed)I have manually tested my changes locally with
./script/run. Not run; the change is covered by parser unit tests and computer-use verification was declined.Agent Mode
CHANGELOG-IMPROVEMENT: Added SSH warpification support for Namespace devbox and cloud commands.