Preserve model preference across team catalog refreshes - #16029
Open
warp-agent-staging[bot] wants to merge 3 commits into
Open
warp-agent-staging[bot] wants to merge 3 commits into
warp-agent-staging[bot] wants to merge 3 commits into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Preserves a shared Agent profile's saved base model and context limit when another team's catalog marks that model
AdminDisabled. Runtime model lookup now resolves against the active team: teams that allow the saved model continue using it, while teams that disable it fall back to their usable Auto model without persisting that fallback. Admin-disabled models remain visible as disabled in the active team's picker.Durable cleanup remains unchanged for globally
Unavailablemodels and non-BYOKRequiresUpgrademodels. This avoids a profile-schema migration and confines the exception to team-admin policy.Linked Issue
QUALITY-2121 · Origin Slack thread
factory:wilson,Model Choice, andBugs; it does not use GitHub'sready-to-implementlabel.Testing
cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp -E 'test(ai::llms::tests)'— 36 passed, 6618 skipped.cargo clippy --manifest-path /workspace/warp/Cargo.toml -p warp --all-targets --tests -- -D warnings— passed./workspace/warp/script/format— completed successfully.I have manually tested my changes locally with
./script/run— not run because the requester chose automated tests only.Agent Mode
CHANGELOG-BUG-FIX: Preserve saved Agent profile model preferences when another team disables the model.