Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR bumps cpal, rustls-platform-verifier, and related transitive dependencies to reduce the Windows dependency tree, with one cpal call-site update for the new by-value StreamConfig API.
Concerns
- The
cpal0.18 bump raises the macOS CoreAudio runtime/build floor to macOS 14.2+, but Warp's macOS bundle/config still targets 10.14 and GUI builds includevoice_input, so this can break macOS builds or shipped binaries for older supported versions.
Audits
- Comments: no comments or doc comments were added or changed in the diff.
- Tests: no tests were added or changed; the issue here needs dependency/platform compatibility validation rather than a new unit test.
- Security: supplemental security pass found no security-specific findings.
- Spec: no approved or repository spec context was provided.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| thiserror = { workspace = true } | ||
| base64 = { workspace = true } | ||
| cpal = "0.17.1" | ||
| cpal = "0.18.2" |
There was a problem hiding this comment.
cpal 0.18 requires CoreAudio on macOS 14.2+ and links process-tap symbols that are unavailable below that, while Warp still sets MACOSX_DEPLOYMENT_TARGET=10.14 and gui pulls in voice_input; please avoid this bump on macOS or gate/reconfigure it so older supported macOS builds keep working.
There was a problem hiding this comment.
@warp-agent what makes you assert that 0.18 breaks compatibility with older versions of macOS? i don't see that in the 0.18 release notes. any chance 0.17 also required macOS 14.2?
1 participant
Description
This eliminates the dependency on one of our last two copies of
windows-targets, which is quite expensive to compile. The last one is probably going to be a pain to remove (many more dependencies), so stopping here.