Workaround winit bug where events execute immediately #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorporeal
approved these changes
May 17, 2024
ddfisher
merged commit 1813f60
into
warpdotdev:warpdotdev/v0.30.x
72 of 104 checks passed
ddfisher
added a commit
that referenced
this pull request
Jun 12, 2024
This reverts commit 1813f60. This is fixed upstream.
ddfisher
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 1813f60. This is fixed upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winit on web has a bug where the
EventLoopProxywill immediately call handlers for a custom event insend_eventinstead of scheduling it for the next event tick. This causes double-borrows of ourMutableAppContext, which hard crashes the app. This is a bandaid fix which pushes those calls on the microtask queue instead.