Generate bindings from a directory #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Workflow Timer ⏱😥 The run time for "Continuous Integration" has regressed a bit by 55s (27.29%) 😥 The current run time is 4mins 17s while |
syrusakbary
reviewed
Nov 14, 2022
syrusakbary
reviewed
Nov 14, 2022
crates/cli/Cargo.toml
Outdated
| @@ -29,6 +29,8 @@ serde = { version = "1.0.145", features = ["derive"] } | |||
| serde_json = "1.0.85" | |||
| webc = "3.0.1" | |||
| wasmer-pack = { version = "0.5.0", path = "../wasmer-pack" } | |||
| wapm-targz-to-pirita = { git = "ssh://[email protected]/wasmerio/pirita.git", version = "0.1.0" } | |||
There was a problem hiding this comment.
I think we may want to publish as well the wapm_targz_to_pirita crate to crates.io? (since the webc crate is already published)
Note: we'll need to use the same license as the webc crate
There was a problem hiding this comment.
Yep, that's the plan.
We can't publish it at the moment because wapm-targz-to-pirita uses a fork of the tar crate to work around alexcrichton/tar-rs#297. We'll probably need to publish our tar fork or come up with some workaround which avoids calling _set_perms().
Michael-F-Bryan
force-pushed
the
from-directory
branch
from
5ed1c99 to
656ddd4
Compare
added 5 commits
November 22, 2022 02:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79.