Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macro to generate most of the UntypedVal API #1391

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Mar 12, 2025

This will simplify design and implementation of #1389.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.48%. Comparing base (bec7883) to head (b34fccd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/untyped.rs 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   70.96%   70.48%   -0.49%     
==========================================
  Files         155      155              
  Lines       14683    14445     -238     
==========================================
- Hits        10420    10181     -239     
- Misses       4263     4264       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit 43624ae into main Mar 12, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-generate-untyped-val-api branch March 12, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant