Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wast tests to wasmi_wast crate #1403

Merged
merged 7 commits into from
Mar 21, 2025
Merged

Conversation

Robbepop
Copy link
Member

This breaks a cyclic dev-dependency between wasmi and wasmi_wast which caused troubles for cargo publish.

Now all Wast based tests reside in wasmi_wast. All Wasmi integration tests remain in Wasmi and have an improved structure.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (fc0d538) to head (7304aeb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   69.39%   69.38%   -0.01%     
==========================================
  Files         158      158              
  Lines       14695    14698       +3     
==========================================
+ Hits        10197    10198       +1     
- Misses       4498     4500       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit b43b41c into main Mar 21, 2025
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-move-wast-tests-to-wasmi-wast branch March 21, 2025 10:14
This was referenced Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant