Repository navigation
feat(webui): show the selected tracker description and ask before using it - #818
Open
clustered1651 wants to merge 1 commit into
Open
clustered1651 wants to merge 1 commit into
clustered1651 wants to merge 1 commit into
Conversation
…ng it Since the GUI output mode (wastaken7#781) sets UA_WEBUI_ACTIVE for Web UI runs, _review_explicit_tracker_description returned silently in those runs and only stored the tracker description as the Description panel's draft. The user never saw which description was picked and was not asked whether to keep it, unlike a terminal run. Web UI runs now behave like terminal runs: the description is printed, a hint points to the Description panel for edits, and the usual keep/discard question is asked through letter_prompt, which already leaves out the "edit" answer when no editor is available. The draft is still saved first so the panel keeps working, and discarding also writes an empty draft so apply_saved_draft cannot bring the tracker text back at upload time. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(webui): show the selected tracker description and ask before using it
Problem
Since the GUI output mode (#781) sets
UA_WEBUI_ACTIVEfor Web UI runs,TrackerDataManager._review_explicit_tracker_descriptionreturns silently in those runs and only stores the tracker description as the Description panel's draft. A terminal run prints "Selected description from :" and asks keep / edit / discard; a Web UI run shows nothing and never asks, so the user does not see which description was picked, and a description they would have discarded ends up in the upload unless they notice the panel.Change
Web UI runs now behave like terminal runs:
webui_events.letter_prompt, which already drops theeanswer when no editor is available (so the GUI shows Keep it / Discard buttons, no editor is ever opened on the server);apply_saved_draftwould bring the tracker text back at upload time.Terminal behaviour is unchanged (same prompt,
estill opens the editor). Unattended runs are unchanged (no prompt).Testing
tests/test_tracker_descriptions.py: the previoustest_webui_tracker_description_is_saved_without_promptingis replaced by three tests: Web UI run saves the draft, prints the description and asks a question without aneoption; aneanswer in a Web UI run does not open the editor; adanswer discards and clears the saved draft. The existing terminal-mode discard test still passes.🤖 Generated with Claude Code