Skip to content

feat(webui): show the selected tracker description and ask before using it - #818

Open
clustered1651 wants to merge 1 commit into
wastaken7:developmentfrom
clustered1651:feat/webui-tracker-description-prompt
Open

clustered1651 wants to merge 1 commit into
wastaken7:developmentfrom
clustered1651:feat/webui-tracker-description-prompt

Conversation

@clustered1651

Copy link
Copy Markdown

feat(webui): show the selected tracker description and ask before using it

Problem

Since the GUI output mode (#781) sets UA_WEBUI_ACTIVE for Web UI runs, TrackerDataManager._review_explicit_tracker_description returns silently in those runs and only stores the tracker description as the Description panel's draft. A terminal run prints "Selected description from :" and asks keep / edit / discard; a Web UI run shows nothing and never asks, so the user does not see which description was picked, and a description they would have discarded ends up in the upload unless they notice the panel.

Change

Web UI runs now behave like terminal runs:

  • the draft is still saved first, so the Description panel keeps working as before;
  • the description (first 1000 characters) is printed, with a hint that edits are made in the Description panel;
  • the keep/discard question is asked through webui_events.letter_prompt, which already drops the e answer when no editor is available (so the GUI shows Keep it / Discard buttons, no editor is ever opened on the server);
  • discarding also writes an empty draft, otherwise apply_saved_draft would bring the tracker text back at upload time.

Terminal behaviour is unchanged (same prompt, e still opens the editor). Unattended runs are unchanged (no prompt).

Testing

  • tests/test_tracker_descriptions.py: the previous test_webui_tracker_description_is_saved_without_prompting is replaced by three tests: Web UI run saves the draft, prints the description and asks a question without an e option; an e answer in a Web UI run does not open the editor; a d answer discards and clears the saved draft. The existing terminal-mode discard test still passes.
  • Full suite green; ruff and pyright unchanged for the touched file.

🤖 Generated with Claude Code

…ng it

Since the GUI output mode (wastaken7#781) sets UA_WEBUI_ACTIVE for Web UI runs,
_review_explicit_tracker_description returned silently in those runs and
only stored the tracker description as the Description panel's draft.
The user never saw which description was picked and was not asked
whether to keep it, unlike a terminal run.

Web UI runs now behave like terminal runs: the description is printed,
a hint points to the Description panel for edits, and the usual
keep/discard question is asked through letter_prompt, which already
leaves out the "edit" answer when no editor is available. The draft is
still saved first so the panel keeps working, and discarding also
writes an empty draft so apply_saved_draft cannot bring the tracker
text back at upload time.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9c18ac61-eea7-47a1-ae8a-8f9924665378
Commits

Reviewing files that changed from the base of the PR and between bcaca03 and 23ae8ba.

Files selected for processing: 2
  • src/get_tracker_data.py
  • tests/test_tracker_descriptions.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant