Make API Endpoint to set the ReadOnly status of a Wiki #1009
+127
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalieper
force-pushed
the
T410395-readonlywiki
branch
from
1fc42a7 to
ebd83fb
Compare
rosalieper
force-pushed
the
T410395-readonlywiki
branch
from
ebd83fb to
c5b00ef
Compare
rosalieper
changed the title
outdooracorn
requested changes
Nov 24, 2025
|
|
||
| if (!$wiki) { | ||
| return response()->json([ | ||
| 'error' => 'Wiki not found for domain: ' . $domain, |
Member
There was a problem hiding this comment.
Suggested change
| 'error' => 'Wiki not found for domain: ' . $domain, | |
| 'error' => "Wiki not found for domain: $domain", |
Non-blocking nitpick: let's make use of string interpolation :)
Comment on lines
12
to
14
| $validated = $request->validate([ | ||
| 'domain' => 'required|string', | ||
| ]); |
Member
There was a problem hiding this comment.
Looking at the task, this endpoint should also take a boolean readOnly parameter
| ], 404); | ||
| } | ||
|
|
||
| $wiki->setSetting('wgReadOnly', 'This wiki is currently read-only.'); |
Member
There was a problem hiding this comment.
Same as above, this doesn't handle when the readOnly parameter is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T410395