Skip to content

Fix flaking _validate_input behaviour with Sequence type #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix flaking _validate_input behaviour with Sequence type #1374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions integration/test_tenants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
from weaviate.collections.classes.tenants import (
Tenant,
TenantCreate,
TenantCreateActivityStatus,
TenantActivityStatus,
TenantUpdateActivityStatus,
TenantUpdate,
)
from weaviate.collections.tenants import TenantCreateInputType
from weaviate.exceptions import WeaviateInvalidInputError, WeaviateUnsupportedFeatureError
Expand Down Expand Up @@ -267,17 +270,23 @@ def test_update_tenant(collection_factory: CollectionFactory) -> None:
assert tenants["1"].activity_status == TenantActivityStatus.ACTIVE

with pytest.warns(DeprecationWarning) as recwarn:
collection.tenants.update(Tenant(name="1", activity_status=TenantActivityStatus.COLD))
collection.tenants.update(
TenantUpdate(name="1", activity_status=TenantUpdateActivityStatus.COLD)
)
assert len(recwarn) == 1
assert any("COLD is deprecated" in warn.message.args[0] for warn in recwarn.list)
tenants = collection.tenants.get()
assert tenants["1"].activity_status == TenantActivityStatus.INACTIVE

collection.tenants.update(Tenant(name="1", activity_status=TenantActivityStatus.ACTIVE))
collection.tenants.update(
TenantUpdate(name="1", activity_status=TenantUpdateActivityStatus.ACTIVE)
)
tenants = collection.tenants.get()
assert tenants["1"].activity_status == TenantActivityStatus.ACTIVE

collection.tenants.update(Tenant(name="1", activity_status=TenantActivityStatus.INACTIVE))
collection.tenants.update(
TenantUpdate(name="1", activity_status=TenantUpdateActivityStatus.INACTIVE)
)
tenants = collection.tenants.get()
assert tenants["1"].activity_status == TenantActivityStatus.INACTIVE

Expand Down Expand Up @@ -452,10 +461,10 @@ def test_tenants_create_and_update_1001_tenants(
collection.tenants.create(tenants)
t = collection.tenants.get()
assert len(t) == 1001
assert all(tenant.activity_status == TenantActivityStatus.ACTIVE for tenant in t.values())
assert all(tenant.activity_status == TenantCreateActivityStatus.ACTIVE for tenant in t.values())

tenants = [
Tenant(name=f"tenant{i}", activity_status=TenantActivityStatus.INACTIVE)
TenantUpdate(name=f"tenant{i}", activity_status=TenantUpdateActivityStatus.INACTIVE)
for i in range(1001)
]
collection.tenants.update(tenants)
Expand Down
Loading