Skip to content

Conversation

nilptr
Copy link
Contributor

@nilptr nilptr commented Dec 19, 2024

changes

  1. asynchronize all fs calls
  2. benchmark only single thread with codspeed and remove resovler cache in benchmark, so the performance degraded

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #38 will degrade performances by 79.69%

Comparing nilptr:nilptr/feat/async (651a49b) with main (64b3262)

Summary

❌ 2 regressions
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ resolver[multi-thread] 90.9 ms N/A N/A
resolver[resolve from symlinks] 71.5 ms 352 ms -79.69%
resolver[single-thread] 86.8 ms 112.1 ms -22.55%

@stormslowly stormslowly force-pushed the nilptr/feat/async branch 2 times, most recently from cfccf22 to 7af89c3 Compare March 31, 2025 03:47
@stormslowly stormslowly changed the title Draft: compare performance with async fs version feat: async fs Apr 3, 2025
@stormslowly stormslowly enabled auto-merge (squash) April 3, 2025 08:44
@stormslowly stormslowly merged commit cc908e8 into web-infra-dev:main Apr 7, 2025
17 of 18 checks passed
@hardfist
Copy link
Contributor

hardfist commented Apr 7, 2025

@nilptr thanks for your effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants