Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: render runtime template with dojang #9450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: render runtime template with dojang #9450

wants to merge 1 commit into from

Conversation

GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Feb 25, 2025 •
edited
Loading

Summary

Use dojang to render runtime modules, related to #5316

More detail summary see: #9079

  • render get_trusted_types_policy with dojang
  • render global with dojang
  • render has_own_property with dojang
  • render rspack_version with dojang

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft February 25, 2025 08:25
@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 25, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e43e45b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bec4b6778e5b0009eb87d1

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9450 will not alter performance

Comparing feat/runtime-template-with_dojang4 (e43e45b) with main (9e378b1)

Summary

✅ 7 untouched benchmarks

@GiveMe-A-Name
feat: render runtime template with dojang
e43e45b 
- render get_trusted_types_policy  with dojang
- render global  with dojang
- render has_own_property  with dojang
- render rspack_version with dojang
@GiveMe-A-Name GiveMe-A-Name force-pushed the feat/runtime-template-with_dojang4 branch from 48f9aab to e43e45b Compare February 26, 2025 07:37
@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review February 26, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiveMe-A-Name @LingyuCoder