Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add module._constructorName #9471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 26, 2025

Summary

Add _constructorName for module, some plugin need to have different behavior for different kind of module, add _constructorName to support that

PS: I'm not sure is there a better solution for this, this PR maybe a temp solution or maybe not, so I use _constructorName with @internal JSDoc for now

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b238511
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67beb78e499cd40008a85628

@ahabhgk ahabhgk requested review from hardfist and SyMind February 26, 2025 06:21
@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 26, 2025
hardfist
hardfist previously approved these changes Feb 26, 2025
@ahabhgk ahabhgk force-pushed the feat-jsapi-constructor-name branch from a3bb4ec to b238511 Compare February 26, 2025 06:41
@ahabhgk ahabhgk enabled auto-merge (squash) February 26, 2025 06:59
@ahabhgk ahabhgk disabled auto-merge February 26, 2025 07:08
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9471 will not alter performance

Comparing feat-jsapi-constructor-name (b238511) with main (912f2b3)

Summary

✅ 7 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants