fix: mock error when external static import to dynamic import #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where external static imports were incorrectly converted to dynamic imports, causing mock factory errors. The fix ensures that external modules maintain their import type as commonjs-import instead of being converted to import or module-import.
- Changed external module handling to use
commonjs-importfor non-CommonJS dependency types - Added test coverage for mocking external node modules with static imports
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/core/plugins/external.ts | Updated external module type resolution to use commonjs-import instead of import or module-import |
| e2e/externals/mock.test.ts | Added test case verifying that external node modules can be properly mocked |
| e2e/externals/fixtures/getFs.ts | Added fixture file with static import of node:fs/promises for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
should not external
static importtodynamic importwhich will cause mock factory error.Related Links
Checklist