[css-tables] Add some subpixel collapsed border tests #15449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 18, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1477334
branch
4 times, most recently
from
c8e6ccd to
d78d1f3
Compare
This CL contains tests only, no behavior change. Chrome passes only 001, no matter the device pixels. Safari-lodpi and Firefox-lodpi pass only 001 and 002. EdgeHTML 18.17763-lodpi, Firefox-hidpi, and Safari-hidpi pass 001, 002, and 003. From a plain reading of the tables spec the 003 test is correct. But given its rampant failure (only EdgeHTML passes when 1x device pixel per CSS pixel), it'd be reasonable to codify the current empirical behavior somewhere, if it's not already in a place that I missed. Chrome probably passes 001 but fails 002 because of LayoutUnit's 1/64 pixel precision but that's not confirmed. Note that these tests will become invalid if the proposal in w3c/csswg-drafts#606 is adopted. Bug: 377847 Change-Id: Ifc9e8f9f878f7462cb949670350eadb17c7c2940 Reviewed-on: https://chromium-review.googlesource.com/c/1477334 Reviewed-by: Morten Stenshorne <[email protected]> Reviewed-by: David Grogan <[email protected]> Commit-Queue: David Grogan <[email protected]> Cr-Commit-Position: refs/heads/master@{#633538}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1477334
branch
from
d78d1f3 to
7a820b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL contains tests only, no behavior change.
Chrome passes only 001, no matter the device pixels.
Safari-lodpi and Firefox-lodpi pass only 001 and 002.
EdgeHTML 18.17763-lodpi, Firefox-hidpi, and Safari-hidpi pass 001, 002,
and 003.
From a plain reading of the tables spec the 003 test is correct. But
given its rampant failure (only EdgeHTML passes when 1x device pixel per
CSS pixel), it'd be reasonable to codify the current empirical behavior
somewhere, if it's not already in a place that I missed.
Chrome probably passes 001 but fails 002 because of LayoutUnit's 1/64
pixel precision but that's not confirmed.
Note that these tests will become invalid if the proposal in
w3c/csswg-drafts#606 is adopted.
Bug: 377847
Change-Id: Ifc9e8f9f878f7462cb949670350eadb17c7c2940
Reviewed-on: https://chromium-review.googlesource.com/c/1477334
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633538}