Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON modules tests for charset, integrity, and MIME type parameters #28606

Merged
merged 1 commit into from
Apr 22, 2021

Commits on Apr 22, 2021

  1. Add JSON modules tests for charset, integrity, and MIME type parameters

    Add JSON modules tests for the following:
    - The <script> element's integrity attribute is respected.
    - JSON modules are always decoded as UTF-8 regardless of Content-Type
      or the document's encoding.  The existing coverage we had on this in
      utf8.tenative.html was renamed to charset.html, refactored, and
      expanded.
    - Adding parameters to the MIME type doesn't prevent it from being
      evaluated as a JSON MIME type.
    
    Note, some of the existing MIME type tests for */*+json still fail
    because it seems the spec issue on these at
    whatwg/mimesniff#112 hasn't been fully
    resolved. I'll follow up with that separately.
    
    Bug: 1132413
    Change-Id: I682de01bbb14b53214fcc16f427a4875f8cfed7f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841103
    Reviewed-by: Domenic Denicola <[email protected]>
    Reviewed-by: Kouhei Ueno <[email protected]>
    Commit-Queue: Dan Clark <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#875274}
    dandclark authored and chromium-wpt-export-bot committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    80c9552 View commit details
    Browse the repository at this point in the history