fix invalid urlpattern test(s)

[anonrig]

Fixes whatwg/urlpattern#239

Port calls canonicalizePort which just calls url parser setter, which removes the leading trailing c0 whitespace characters from the input.

cc @annevk @lucacasonato @sisidovski

[wpt-pr-bot]

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

[annevk]

cc @sisidovski

[annevk]

Aside: are there no tests where port is assigned to something that is clearly not a port?

[anonrig]

Aside: are there no tests where port is assigned to something that is clearly not a port?

@annevk I'm not sure. By the way, port is not the only wrong test here. As I progress with Ada's implementation, it seems hostname tests are also wrong.

[anonrig]

@annevk I've added a new commit that includes a test for a failing port field.

[lucacasonato]

See whatwg/urlpattern#239 (comment) - I am not entirely sure your analysis for port is correct.

[annevk]

It seems that concern was resolved.

@sisidovski and @jeremyroman can you please review this?

[sisidovski]

I don't quite follow what the intention of this test case is. Could you help me to understand?

[anonrig]

Definitely. It tests the maximum valid port number. If it is greater than 65k, it should throw (according to url spec)

[sisidovski]

Thanks. This is for the step 2.1.2 in the port state in the basic-url-parser. That makes sense.

[sisidovski]

Thanks. This is for the step 2.1.2 in the port state in the basic-url-parser. That makes sense.

[sisidovski]

Why are \n, \r, and \t just stripped?

[anonrig]

This is defined in URL spec. All ascii tab or newline are removed from the input before any parsing is done.

Remove all ASCII tab or newline from input.

[sisidovski]

Thanks, bad\nhostname is passed as input to basic url parser, and those are removed in the step 3.

[sisidovski]

Could you clarify why only #%/ don't throw errors and other hostname patterns like "bad\:hostname" or "bad>hostname" continue throw errors?

btw I noticed "bad\:hostname" updates hostname in URL.

u = new URL('http:/dummy.site')
u.hostname = "bad\\:hostname"
u.hostname  // bad

[anonrig]

Host parser (specifically domain to ASCII with domain and false) strip all trailing values whenever it sees # https://url.spec.whatwg.org/#concept-host-parser

[annevk]

The host parser does not do that. Do you mean the host setter or some such?

[anonrig]

The host parser does not do that. Do you mean the host setter or some such?

Yes, I meant the host setter, which calls the host parser.

Could you clarify why only #%/ don't throw errors and other hostname patterns like "bad:hostname" or "bad>hostname" continue throw errors?

@sisidovski Sorry I missed this comment. URL spec hostname state step 3 (ref: https://url.spec.whatwg.org/#hostname-state) says that...

if c is the EOF code point, U+002F (/), U+003F (?), or U+0023 (#) ... then decrease pointer by 1, and then: ... Let host be the result of host parsing buffer with url is not special.

So, if you see these characters, we take the existing non-empty buffer and parse it as a valid hostname.

[anonrig]

@annevk @sisidovski would you mind taking one last look at this? I've tried to address your questions and i think this is ready to land.

[sisidovski]

Looks good to me. Thanks!

[sisidovski]

Thanks, bad\nhostname is passed as input to basic url parser, and those are removed in the step 3.

[annevk]

I'll rubber-stamp so this can land. @sisidovski you should ask on the web-platform-tests Matrix chat for contributor access.