Skip to content

Stop component re-rendering with useSelector #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stop component re-rendering with useSelector #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e28de80
feat: useSelector
GeraldHost Aug 6, 2021
fcb83f7
feat: build cjs and esm
GeraldHost Aug 10, 2021
7fe7f9a
feat: remove build
GeraldHost Aug 31, 2021
6d48722
feat: prepare
GeraldHost Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
.idea
dist/
3 changes: 0 additions & 3 deletions dist/e.d.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/e.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions dist/e.native.d.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/e.native.js
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions dist/index.d.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/index.js
View file
Open in desktop

This file was deleted.

9,047 changes: 9,047 additions & 0 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,20 @@
"name": "react-ridge-state",
"version": "4.2.1",
"description": "react-ridge-state is a very simple global state management library for React and React Native",
"main": "dist/index.js",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
"homepage": "https://github.com/web-ridge/react-ridge-state",
"license": "MIT",
"readme": "README.md",
"scripts": {
"mocha": "mocha -r jsdom-global/register -r ts-node/register tests/**/*.mocha.tsx",
"jest": "jest --maxWorkers=150",
"build": "tsc && npx esbuild ./src/* --outdir=dist --minify"
"build:tsc": "tsc",
"build:esm": "npx esbuild ./src/* --outdir=dist/esm --minify --format=esm",
"build:cjs": "tsc && npx esbuild ./src/* --outdir=dist/cjs --minify --format=cjs",
"build": "npm run build:tsc && npm run build:esm && npm run build:cjs",
"prepare": "npm run build"
},
"devDependencies": {
"@babel/plugin-transform-runtime": "^7.13.10",
Expand Down
8 changes: 6 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,12 @@ export function newRidgeState<T>(iv: T, o?: Options<T>): StateWithValue<T> {
se: (state: T) => TSelected,
eq = equ as any
): TSelected {
const [rv] = use();
return me(se(rv), eq);
const [l, s] = R.useState<TSelected>();
sub((nv) => {
const v = se(nv);
if (!eq(v, l)) s(v);
});
return l;
Comment on lines +111 to +116
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's not initialized properly. Recommend updating this useState(() => selector(v)); and making a new PR since the code has divergged.

  function useSelector(selector, comparator = equ) {
    const [state, setState] = useState(() => selector(v));
    subscribe(() => {
      const selectedValue = selector(v);
      if (!comparator(selectedValue, state)) setState(selectedValue);
    });
    return state;
  }

}

return {
Expand Down