Skip to content

Conversation

@danforbes
Copy link
Contributor

Refer to the documentation for additional details.

@danforbes danforbes force-pushed the feat/templates/react-demo branch 3 times, most recently from 6dbb961 to 916b3b3 Compare October 2, 2024 17:15
@danforbes danforbes force-pushed the feat/templates/react-demo branch from 916b3b3 to d0e1b9b Compare October 2, 2024 17:17
@luu-alex
Copy link

luu-alex commented Oct 3, 2024

templates/demo/web3js-react-dapp-demo/src/App.css is an empty file, other than that it lgtm!

@danforbes
Copy link
Contributor Author

templates/demo/web3js-react-dapp-demo/src/App.css is an empty file, other than that it lgtm!

This is another thing that was inherited from create-react-app...I agree it's kind of odd.

@danforbes
Copy link
Contributor Author

templates/demo/web3js-react-dapp-demo/src/App.css is an empty file, other than that it lgtm!

This is another thing that was inherited from create-react-app...I agree it's kind of odd.

Nope sorry this is wrong - https://github.com/facebook/create-react-app/blob/main/packages/cra-template-typescript/template/src/App.css

@krzysu
Copy link

krzysu commented Oct 7, 2024

Hey, great PR! I was just wondering if it might also be valuable to show how devs can switch chains using web3js. Personally, I use the Rabby Wallet, which hides the chain selection from the user and lets the dApp decide which chain to use. However, I’ve noticed the demo dApp in this PR only works with chainID 1 when using Rabby.

@danforbes
Copy link
Contributor Author

Hey, great PR! I was just wondering if it might also be valuable to show how devs can switch chains using web3js. Personally, I use the Rabby Wallet, which hides the chain selection from the user and lets the dApp decide which chain to use. However, I’ve noticed the demo dApp in this PR only works with chainID 1 when using Rabby.

Yes this is a great suggestion but I don't think it fits into this demonstration template at this time. Today in the Web3.js plugin meeting we talked about this Issue, which seems very related web3/web3.js#6946

@danforbes danforbes merged commit 87fd705 into main Oct 7, 2024
4 checks passed
@danforbes danforbes deleted the feat/templates/react-demo branch October 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants