Skip to content

fix(settings): list built-in provider default models #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webbrain-one merged 1 commit into from
Aug 17, 2026
+46 −6
Merged

fix(settings): list built-in provider default models #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/chrome/src/ui/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2663,7 +2663,7 @@ function renderProviders() {
fields: [
{ key: 'apiKey', labelKey: 'st.provider.field.api_key', type: 'password', placeholder: 'AIza...' },
{ key: 'model', labelKey: 'st.provider.field.model', type: 'text', placeholder: 'gemini-3.1-pro',
suggestions: ['gemini-3.1-pro', 'gemini-3-flash', 'gemini-3.5-flash', 'gemini-3.1-flash-lite'] },
suggestions: ['gemini-3.1-pro', 'gemini-3.1-flash', 'gemini-3-flash', 'gemini-3.5-flash', 'gemini-3.1-flash-lite'] },
{ key: 'baseUrl', labelKey: 'st.provider.field.api_base_url', type: 'text', placeholder: 'https://generativelanguage.googleapis.com/v1beta/openai' },
...COST_ESTIMATE_FIELDS,
],
Expand All @@ -2683,7 +2683,7 @@ function renderProviders() {
fields: [
{ key: 'apiKey', labelKey: 'st.provider.field.api_key', type: 'password', placeholder: 'API key' },
{ key: 'model', labelKey: 'st.provider.field.model', type: 'text', placeholder: 'mistral-medium-3.5',
suggestions: ['mistral-medium-3.5', 'mistral-small-4', 'codestral-25.08', 'devstral-medium'] },
suggestions: ['mistral-medium-3.5', 'mistral-large-latest', 'mistral-small-4', 'codestral-25.08', 'devstral-medium'] },
{ key: 'baseUrl', labelKey: 'st.provider.field.api_base_url', type: 'text', placeholder: 'https://api.mistral.ai/v1' },
...COST_ESTIMATE_FIELDS,
],
Expand All @@ -2710,7 +2710,7 @@ function renderProviders() {
fields: [
{ key: 'apiKey', labelKey: 'st.provider.field.api_key', type: 'password', placeholder: 'nvapi-...' },
{ key: 'model', labelKey: 'st.provider.field.model', type: 'text', placeholder: 'nvidia/llama-3.3-nemotron-super-49b',
suggestions: ['nvidia/llama-3.3-nemotron-super-49b', 'nvidia/llama-3.1-nemotron-70b-instruct', 'nvidia/nemotron-nano-9b-v2', 'meta/llama-3.3-70b-instruct', 'deepseek-ai/deepseek-r1'] },
suggestions: ['nvidia/llama-3.3-nemotron-super-49b', 'nvidia/llama-3.1-nemotron-70b-instruct', 'nvidia/nemotron-nano-9b-v2', 'meta/llama-3.3-70b-instruct', 'meta/llama-3.1-8b-instruct', 'deepseek-ai/deepseek-r1'] },
{ key: 'baseUrl', labelKey: 'st.provider.field.api_base_url', type: 'text', placeholder: 'https://integrate.api.nvidia.com/v1' },
...COST_ESTIMATE_FIELDS,
],
Expand Down
6 changes: 3 additions & 3 deletions src/firefox/src/ui/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2290,7 +2290,7 @@ function renderProviders() {
fields: [
{ key: 'apiKey', labelKey: 'st.provider.field.api_key', type: 'password', placeholder: 'AIza...' },
{ key: 'model', labelKey: 'st.provider.field.model', type: 'text', placeholder: 'gemini-3.1-pro',
suggestions: ['gemini-3.1-pro', 'gemini-3-flash', 'gemini-3.5-flash', 'gemini-3.1-flash-lite'] },
suggestions: ['gemini-3.1-pro', 'gemini-3.1-flash', 'gemini-3-flash', 'gemini-3.5-flash', 'gemini-3.1-flash-lite'] },
{ key: 'baseUrl', labelKey: 'st.provider.field.api_base_url', type: 'text', placeholder: 'https://generativelanguage.googleapis.com/v1beta/openai' },
...COST_ESTIMATE_FIELDS,
],
Expand All @@ -2310,7 +2310,7 @@ function renderProviders() {
fields: [
{ key: 'apiKey', labelKey: 'st.provider.field.api_key', type: 'password', placeholder: 'API key' },
{ key: 'model', labelKey: 'st.provider.field.model', type: 'text', placeholder: 'mistral-medium-3.5',
suggestions: ['mistral-medium-3.5', 'mistral-small-4', 'codestral-25.08', 'devstral-medium'] },
suggestions: ['mistral-medium-3.5', 'mistral-large-latest', 'mistral-small-4', 'codestral-25.08', 'devstral-medium'] },
{ key: 'baseUrl', labelKey: 'st.provider.field.api_base_url', type: 'text', placeholder: 'https://api.mistral.ai/v1' },
...COST_ESTIMATE_FIELDS,
],
Expand All @@ -2337,7 +2337,7 @@ function renderProviders() {
fields: [
{ key: 'apiKey', labelKey: 'st.provider.field.api_key', type: 'password', placeholder: 'nvapi-...' },
{ key: 'model', labelKey: 'st.provider.field.model', type: 'text', placeholder: 'nvidia/llama-3.3-nemotron-super-49b',
suggestions: ['nvidia/llama-3.3-nemotron-super-49b', 'nvidia/llama-3.1-nemotron-70b-instruct', 'nvidia/nemotron-nano-9b-v2', 'meta/llama-3.3-70b-instruct', 'deepseek-ai/deepseek-r1'] },
suggestions: ['nvidia/llama-3.3-nemotron-super-49b', 'nvidia/llama-3.1-nemotron-70b-instruct', 'nvidia/nemotron-nano-9b-v2', 'meta/llama-3.3-70b-instruct', 'meta/llama-3.1-8b-instruct', 'deepseek-ai/deepseek-r1'] },
{ key: 'baseUrl', labelKey: 'st.provider.field.api_base_url', type: 'text', placeholder: 'https://integrate.api.nvidia.com/v1' },
...COST_ESTIMATE_FIELDS,
],
Expand Down
40 changes: 40 additions & 0 deletions test/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49028,6 +49028,46 @@ test('duplicate provider controls are wired through background and settings in b
}
});

test('curated core provider model selectors include their built-in defaults', () => {
const expectedCuratedProviders = [
'alibaba', 'anthropic', 'cloudflare', 'deepseek', 'fireworks', 'gemini', 'groq',
'huggingface', 'kimi', 'minimax', 'mistral', 'nvidia', 'openai', 'openrouter',
'together', 'xai', 'z_ai',
];

for (const [label, PM, settingsRel] of [
['chrome', ProviderManagerCh, 'src/chrome/src/ui/settings.js'],
['firefox', ProviderManagerFx, 'src/firefox/src/ui/settings.js'],
]) {
const source = fs.readFileSync(path.join(ROOT, settingsRel), 'utf8');
const catalogMatch = source.match(/const providerConfigs = \{([\s\S]*?)^ \};\r?$/m);
assert.ok(catalogMatch, `${label}: provider config catalog was not found`);
const catalog = catalogMatch[1];
const blocks = [...catalog.matchAll(/^ ([a-z0-9_]+): \{([\s\S]*?)^ \},/gm)];
const defaults = new PM()._defaultConfigs();
const curatedProviderIds = [];

for (const [, id, body] of blocks) {
const modelField = body.match(/\{ key: 'model'[\s\S]*?suggestions: \[([\s\S]*?)\] \}/);
if (!modelField) continue;
curatedProviderIds.push(id);
const suggestions = [...modelField[1].matchAll(/'([^']+)'/g)].map(match => match[1]);
const defaultModel = defaults[id]?.model;
assert.ok(defaultModel, `${label}: curated provider ${id} has no built-in default model`);
assert.ok(
suggestions.includes(defaultModel),
`${label}: ${id} default model ${JSON.stringify(defaultModel)} is shown as Custom`,
);
}

assert.deepEqual(
curatedProviderIds.sort(),
expectedCuratedProviders,
`${label}: curated provider model selector coverage changed`,
);
}
});

test('_defaultConfigs: every entry carries an explicit category', () => {
// Walk the actual default config table on each platform and assert
// each entry has a category field. Catches "I added a provider but
Expand Down
Loading