feat(ci,deps): Add CI workflow to enforce general Internet Explorer compatibility #153
Conversation
- modern JS most places - ES5 in interceptor, to ensure Internet Explorer's JS runtime can parse the script without breaking - Not all code paths are _executable_ by the IE runtime, though!
not correctly supported by IE < 11, and poorly supported in IE 11
- commit results of `npm run fix`
- use linux hosts, rather than macos, since they are much more available - use setup-node v2, with npm caching
run it on every push, because contributors shouldn't have to wait until they open a PR _and_ a maintainer approves a CI run to get feedback
|
@chmanie you can approve the CI again; the The newly added workflows will not run here; they need to be on the default branch for GitHub to pick them up. You can see the ones that execute on my fork here: https://github.com/tehhowch/wdio-intercept-service/actions |
|
This looks brilliant! Thanks for doing the spring cleaning here. Once the tests pass, I think we can merge this. @tehhowch if you're planning on putting up more PRs here, I'll happily give you write access, so that the flow here will be a bit smoother. |
This repo uses sync wdio for tests, so that cannot be done yet. I don't plan on converting to async in this PR either. |
Makes sense 👍 |
|
@christian-bromann thoughts on why the CI job fails to execute the test? (I could add an artifact upload step to share the |
|
@tehhowch yeah, would be great to see the wdio logs. The output dir is defined as |
tehhowch
force-pushed
the
ci/add-eslint
branch
2 times, most recently
from
36a27c6 to
3b43f43
Compare
tehhowch
force-pushed
the
ci/add-eslint
branch
from
d0e9185 to
413ea5d
Compare
|
@christian-bromann relevant log message is from the test log (wdio-0-0.log): Seems like this particular issue should be an error, not a warning, and get surfaced in the actual test output rather than just logs. (Going off of the "status 500" bit as a proxy for "internal server error"). Anyway, resolved by updating the wdio-chromedriver-service to 7.2 and passing the chromedriverCustomPath option, using the chromedriver that is shipped in the VM by GitHub. |
|
Looks like the CI tests are incredibly slow due to a forced 10s wait per test case. Seems like the functionality of #111 would really help accelerate the tests and remove the "how long do we need to wait?" uncertainty. Link to test run: https://github.com/tehhowch/wdio-intercept-service/actions/runs/1394780199 |
Nice! |
|
@chmanie I think we're set here; I did some bonus cleanup on the old Renovate integration. There may be some administrative settings that need to be ticked in addition to the dependabot config added here to restore automatic dependency upgrades, but I think that should be all. |
|
This looks great! Thanks a lot! Really appreciate it |
Enforces that Internet Explorer will at least be able to parse
interceptor.js. IE was already not able to execute all code paths unless the website in question has polyfilled bothfetchandPromise.all.This PR addresses #152 partially, in that it provides a basic guarantee that the library is not utterly broken for Internet Explorer. This PR does not aim to fulfill all of #152, specifically actually executing tests for all supported browsers.
Other changes