Skip to content

Commit

Permalink
fix VSCodeOptions
Browse files Browse the repository at this point in the history
  • Loading branch information
christian-bromann committed Jul 13, 2022
1 parent 267aef5 commit d79b2be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class VSCodeWorkerService implements Services.ServiceInstance {
customArgs.extensionTestsPath = slash(path.join(__dirname, 'proxy', 'index.js'))
customArgs.userDataDir = slash(path.join(storagePath.path, 'settings'))
customArgs.extensionsDir = slash(path.join(storagePath.path, 'extensions'))
customArgs.vscodeBinaryPath = this._vscodeOptions.binary
customArgs.vscodeBinaryPath = this._vscodeOptions.binary as string

log.info(`Setting up VSCode directory at ${userSettingsPath}`)
await fs.mkdir(userSettingsPath, { recursive: true })
Expand Down
5 changes: 3 additions & 2 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ export interface VSCodeOptions {
/**
* Path to custom VSCode installation
*/
binary: string
binary?: string
/**
* Define the directory to the extension you want to test
* @required
*/
extensionPath: string
/**
Expand Down Expand Up @@ -105,7 +106,7 @@ export interface VSCodeOptions {
/**
* VSCode API proxy configurations
*/
vscodeProxyOptions: Partial<VSCodeProxyOptions>
vscodeProxyOptions?: Partial<VSCodeProxyOptions>
}

export interface WDIOLogs {
Expand Down

0 comments on commit d79b2be

Please sign in to comment.