-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md and tsconfig.json #104
Update README.md and tsconfig.json #104
Conversation
Co-authored-by: Sean Poulter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, one question
README.md
Outdated
@@ -348,7 +340,6 @@ The following VS Code extensions use `wdio-vscode-service`: | |||
- [Live Server](https://marketplace.visualstudio.com/items?itemName=ritwickdey.LiveServer) (27.8m downloads) | |||
- [DVC Extension for Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=Iterative.dvc) (11.2k downloads) | |||
- [Nx Console](https://marketplace.visualstudio.com/items?itemName=nrwl.angular-console) (1.2m downloads) | |||
- [inlang – i18n supercharged](https://marketplace.visualstudio.com/items?itemName=inlang.vs-code-extension) (3k downloads) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing this? They still seem to use WebdriverIO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I checked out the README from your branch and didn't catch this or the section above in the diff. 🤦 Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
3c07ac1
into
webdriverio-community:main
Hey seanpoulter 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Context
It seems like it's hard for both of us to find time to look at all of #94. Here's the easy changes as a separate PR.
Proposed Changes
Extracted from #94:
Notes
When I run this locally from an Ubuntu VM, there are two spec failures:
:wdio-vscode-service
not a path segment like/wdio-vscode-service
.