Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and tsconfig.json #104

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

seanpoulter
Copy link
Contributor

Context

It seems like it's hard for both of us to find time to look at all of #94. Here's the easy changes as a separate PR.

Proposed Changes

Extracted from #94:

  • Update the README.md
  • Change the module resolution type

Notes

When I run this locally from an Ubuntu VM, there are two spec failures:

  • One test case fails in problemsview.e2e.ts because we skip the second test case that adds Problems, but still run the third that checks for their existence.
  • One test case fails in bottombar.e2e.ts because the copy command needs a different keyboard shortcut, and we're expecting the terminal to include :wdio-vscode-service not a path segment like /wdio-vscode-service.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, one question

README.md Outdated
@@ -348,7 +340,6 @@ The following VS Code extensions use `wdio-vscode-service`:
- [Live Server](https://marketplace.visualstudio.com/items?itemName=ritwickdey.LiveServer) (27.8m downloads)
- [DVC Extension for Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=Iterative.dvc) (11.2k downloads)
- [Nx Console](https://marketplace.visualstudio.com/items?itemName=nrwl.angular-console) (1.2m downloads)
- [inlang – i18n supercharged](https://marketplace.visualstudio.com/items?itemName=inlang.vs-code-extension) (3k downloads)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this? They still seem to use WebdriverIO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I checked out the README from your branch and didn't catch this or the section above in the diff. 🤦 Fixed

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@christian-bromann christian-bromann merged commit 3c07ac1 into webdriverio-community:main Feb 12, 2024
0 of 9 checks passed
@seanpoulter seanpoulter deleted the tidy-first branch February 13, 2024 05:26
@wdio-bot
Copy link
Collaborator

Hey seanpoulter 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants