Fix problems with cachePath service option #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `vscode` service with the `cachePath` option:
```js
services: [["vscode", {cachePath: "/tmp/wdio-vscode-service"}]],
```
On the `6.0.0` version this results failure to run tests with this error:
```
ERROR @wdio/runner: Error: Invalid or unsupported WebDriver capabilities found ("cachePath"). Ensure to only use valid W3C WebDriver capabilities (see https://w3c.github.io/webdriver/#capabilities).If you run your tests on a remote vendor, like Sauce Labs or BrowserStack, make sure that you put them into vendor specific capabilities, e.g. "sauce:options" or "bstack:options". Please reach out to your vendor support team if you have further questions.
```
Seems like `cachePath` is not a capability based on any of the wdio types.
Looking at the code, it seems like before assigning `options` to the
capabilities made sense because `options` field actually contained different
things in the wdio-chromedriver-service - https://github.com/webdriverio-community/wdio-chromedriver-service/blob/104e63525faa156866aa521397ae56ffc6059a8f/src/launcher.ts#L47
Right now the options are only relevant for the `vscode` service, so I've
removed all logic that merges them into capabilities.
christian-bromann
requested changes
Feb 16, 2024
|
Oh no, sorry I didn't catch that in the previous PR. Is it worth adding a test case that uses |
|
The build fails for the same reason as webdriverio/webdriverio#12305. I'll open a PR to bump those dependencies when the workflows pass. Edit: #108 |
seanpoulter
approved these changes
Feb 20, 2024
christian-bromann
approved these changes
Feb 20, 2024
christian-bromann
merged commit c4585c6
into
webdriverio-community:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
vscodeservice with thecachePathoption:On the
6.0.0version this results in a failure to run tests:cachePathis indeed not a capability based on any of the wdio or webdriver types.Looking at the old
5.*code, assigningoptionsto the capabilities made sense becauseoptionsfield actually contained different things in thewdio-chromedriver-service/launcherbase class.Right now the options are only relevant for the
vscodeservice, so I've removed all logic that merges them into capabilities.