Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy terminal selection on Linux #114

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

seanpoulter
Copy link
Contributor

@seanpoulter seanpoulter commented Feb 26, 2024

This will close #103.

Problem

We assume the command to copy from the terminal is Ctrl--c:

[chrome 114.0.5735.289 linux #0-0] » /test/specs/bottombar.e2e.ts
[chrome 114.0.5735.289 linux #0-0] bottombar
[chrome 114.0.5735.289 linux #0-0]    ✖ can read from terminal @skipWeb

Proposed Changes

  • fix: Copy terminal selection on Linux
  • test: Enable passing tests

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 💯

@seanpoulter
Copy link
Contributor Author

I'll revert all the changes except changing the copy implementation. We have confidence it works. We can troubleshoot those other failing tests another day.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seanpoulter seanpoulter merged commit f57cd0b into webdriverio-community:main Feb 27, 2024
9 checks passed
@seanpoulter seanpoulter deleted the issue-103 branch March 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getText fails on Linux / Ubuntu
2 participants