-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contain side-effects from tests in C/I #99
Contain side-effects from tests in C/I #99
Conversation
Test passed for various vscode versions on a Linux box (in codespaces). Hopefully 🤞 this will make them pass in GH actions, @christian-bromann. |
Thanks for the patch 👌 |
@sourishkrout shouldn't we remove the tests from the |
I believe the whole file was removed. If not then I must have done something wrong during commit. Checking.... Also... Windows 🤦. |
Yes, thanks for confirming. The GitHub UI tricked me here. |
Just pushed a wdio config change to turn on retries for occasional flakes @christian-bromann. |
I will rerun this a couple of times, knowing that some of these tests aren't stable. |
Got one of the culprits to pass consistently locally. Let's see if we can get a clean build, please, @christian-bromann. |
Chromedriver/Electron didn't even come up in the last run. Don't think that's related to the new commits. Crashed prematurely. |
🤦 whackamole continues |
🤞 hopefully this will fix it @christian-bromann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot!
fc9e263
into
webdriverio-community:main
Follow up to #98.