Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): provide option for disabling console warn messages #320

Closed

Conversation

jgraniero
Copy link

Add noWarn client parameter.

resolves #319

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add support for disabling console.warn messages on the client.

Resolves #319

Breaking Changes

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jul 10, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jgraniero
❌ Joseph Graniero


Joseph Graniero seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

Merging #320 into master will decrease coverage by 0.32%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage    87.5%   87.17%   -0.33%     
==========================================
  Files           3        3              
  Lines         232      234       +2     
  Branches       65       66       +1     
==========================================
+ Hits          203      204       +1     
- Misses         29       30       +1
Impacted Files Coverage Δ
client.js 85.18% <50%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d46df6...93a22e3. Read the comment docs.

@jgraniero
Copy link
Author

Looks like my git settings were misconfigured. Not sure how to resolve the CLA issue.

@jgraniero jgraniero closed this Jul 10, 2018
@jgraniero jgraniero deleted the feature/no-warning branch July 10, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress / filter console warning messages
2 participants