Fix overlay not showing on Webpack v5 #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can somebody from maintainers please push this over the last mile? |
|
@glenjamin please could you look at merging this? |
|
Thanks for submitting this, it really helped me nail down what had changed. I've taken a different approach to the fix in #397 - having the middleware code on the server coerce the data back into the old string format. |
giterium
pushed a commit
to giterium/booking
that referenced
this pull request
Jan 31, 2021
…middleware added manually PR webpack-contrib/webpack-hot-middleware#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR contains fix for overlay issue in Webpack 5 (#392)
Webpack 5 has a bit different way of handling errors with new error structure, so overlay was not working.
This fix is backward compatible with older Webpack versions (tested with both v4 and v5)
Cheers,
Taras