perf: optimize buffer input processing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antongolub Look like it's time |
antongolub
requested changes
Jan 10, 2025
src/main/ts/envapi.ts
Outdated
| @@ -6,6 +6,15 @@ const Q1 = '"' // double quote | |||
| const Q2 = "'" // single quote | |||
| const Q3 = '`' // backtick | |||
|
|
|||
| const utf8Decoder = new TextDecoder('utf-8') | |||
There was a problem hiding this comment.
const {decode} = new TextDecoder('utf-8')There was a problem hiding this comment.
It won't work that way and I don't want to bind
TypeError [ERR_INVALID_THIS]: Value of "this" must be of type TextDecoder
src/main/ts/envapi.ts
Outdated
| @@ -22,7 +31,7 @@ export const parse = (content: string | Buffer): NodeJS.ProcessEnv => { | |||
| } | |||
| } | |||
|
|
|||
| for (const c of content.toString().replace(/\r\n?/mg, '\n')) { | |||
| for (const c of bufToString(content).toString().replace(/\r\n?/mg, '\n')) { | |||
There was a problem hiding this comment.
for (const c of (typeof content === 'string' ? content : decode(content))) {
src/test/ts/index.test.ts
Outdated
| @@ -70,6 +70,44 @@ JSON='{"foo": "b a r"}' | |||
| JSONSTR='{"foo": "b a r"}'` | |||
| ) | |||
| }) | |||
| test("works with buffer with different encoding", () => { | |||
There was a problem hiding this comment.
To verbose. Check typecast, not all cases. FOO=BAR\r\nBAZ=QUZ is enough
easymikey
force-pushed
the
feat-proccessing-buffers
branch
from
77e8d2b to
97cf634
Compare
easymikey
force-pushed
the
feat-proccessing-buffers
branch
from
97cf634 to
5d0d111
Compare
antongolub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2