Repository navigation
perf: optimize buffer input processing - #4
Merged
Merged
Conversation
Contributor
Author
|
@antongolub Look like it's time |
antongolub
requested changes
Jan 10, 2025
antongolub
left a comment
antongolub
left a comment
Member
There was a problem hiding this comment.
Add nodejs v7 to test matrix
| const Q2 = "'" // single quote | ||
| const Q3 = '`' // backtick | ||
|
|
||
| const utf8Decoder = new TextDecoder('utf-8') |
Member
There was a problem hiding this comment.
const {decode} = new TextDecoder('utf-8')
Contributor
Author
There was a problem hiding this comment.
It won't work that way and I don't want to bind
TypeError [ERR_INVALID_THIS]: Value of "this" must be of type TextDecoder
| } | ||
|
|
||
| for (const c of content.toString().replace(/\r\n?/mg, '\n')) { | ||
| for (const c of bufToString(content).toString().replace(/\r\n?/mg, '\n')) { |
Member
There was a problem hiding this comment.
for (const c of (typeof content === 'string' ? content : decode(content))) {| JSONSTR='{"foo": "b a r"}'` | ||
| ) | ||
| }) | ||
| test("works with buffer with different encoding", () => { |
Member
There was a problem hiding this comment.
To verbose. Check typecast, not all cases. FOO=BAR\r\nBAZ=QUZ is enough
antongolub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2